Skip to content

Allow Nested Components#1

Open
dkaoster wants to merge 2 commits into
masterfrom
nested-components
Open

Allow Nested Components#1
dkaoster wants to merge 2 commits into
masterfrom
nested-components

Conversation

@dkaoster
Copy link
Copy Markdown

@dkaoster dkaoster commented May 2, 2023

Allows react-animated-dataset to recursively nest itself in order to create more complex hierarchies, such as specified in accurat#31.

@harrislapiroff Should I try to open a PR against the accurat version or should we switch over to a fork we maintain?

@harrislapiroff
Copy link
Copy Markdown

Let's test this on our own projects for a few weeks once we merge freedomofpress/pressfreedomtracker.us#1651 and, if we're satisfied, put this PR in upstream

@sssoleileraaa
Copy link
Copy Markdown

freedomofpress/pressfreedomtracker.us#1651 has been merged! So can now start testing and in two weeks time can make an upstream PR if we're happy with it. (Keeping in blocked state still in the meantime.)

@harrislapiroff
Copy link
Copy Markdown

I think we're satisfied with this. @dkaoster can you redirect this PR upstream to accurat's repo with appropriate documentation?

@harrislapiroff
Copy link
Copy Markdown

The upstream PR is here accurat#32

Let's keep using this branch of this fork for our projects for the time being and leave this PR open to remind ourselves of where it lives. If we start adding a bunch of other features we may wish to merge this and work off the main branch of our fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants